Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] test snapshot operations on powered off vm #5159

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

apagac
Copy link
Contributor

@apagac apagac commented Aug 15, 2017

This is a new test for testing basic snapshot operations on a powered off vm.

Snapshot create, revert and delete.

@apagac
Copy link
Contributor Author

apagac commented Aug 15, 2017

Still references selenium. This will change after PR #5124 merge.

@apagac
Copy link
Contributor Author

apagac commented Aug 16, 2017

PRT is failing on unrelated test, this will go away with PR #5126 merge.

@apagac apagac changed the title [WIPTEST] test snapshot operations on powered off vm [WIP] test snapshot operations on powered off vm Aug 18, 2017
@dajoRH dajoRH added WIP and removed WIP-testing labels Aug 18, 2017
@apagac apagac force-pushed the snpsht_powered_off branch from d73bd9c to eb5d94a Compare August 23, 2017 13:40
@apagac apagac changed the title [WIP] test snapshot operations on powered off vm [WIPTEST] test snapshot operations on powered off vm Aug 23, 2017
@dajoRH dajoRH added WIP-testing and removed WIP labels Aug 23, 2017
@apagac apagac changed the title [WIPTEST] test snapshot operations on powered off vm [WIP] test snapshot operations on powered off vm Aug 30, 2017
@apagac
Copy link
Contributor Author

apagac commented Aug 30, 2017

Now waiting for PR #5124 that contains fix for NameError and snapshot.refresh.

@dajoRH dajoRH added WIP and removed WIP-testing labels Aug 30, 2017
@apagac apagac force-pushed the snpsht_powered_off branch from eb5d94a to 30d0503 Compare August 30, 2017 14:07
@apagac apagac changed the title [WIP] test snapshot operations on powered off vm [WIPTEST] test snapshot operations on powered off vm Aug 30, 2017
@dajoRH dajoRH added WIP-testing and removed WIP labels Aug 30, 2017
@apagac
Copy link
Contributor Author

apagac commented Aug 30, 2017

PRT 5.7 fails on unrelated test, so moving this to RFR.

Dependent PR was merged, this was rebased and refactored.

@apagac apagac changed the title [WIPTEST] test snapshot operations on powered off vm [RFR] test snapshot operations on powered off vm Aug 30, 2017
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Aug 31, 2017
small_test_vm.power_control_from_cfme(option=small_test_vm.POWER_OFF, cancel=False)
small_test_vm.wait_for_vm_state_change(desired_state=small_test_vm.STATE_OFF)
# Create first snapshot
snapshot1 = new_snapshot(small_test_vm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question for second level review: should we consider having a helper for the creation of a snapshot as a followup with a more nice api as this test needs to do quite some plumbing due to low level of the api provided

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be resolved with collections? You should then be able to do something like vm.snapshots.create(...) ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfalesni perfect point, thanks 👍

@RonnyPfannschmidt RonnyPfannschmidt changed the title [RFR] test snapshot operations on powered off vm [1LP][RFR] test snapshot operations on powered off vm Aug 31, 2017
@RonnyPfannschmidt RonnyPfannschmidt removed their assignment Aug 31, 2017
Copy link
Contributor

@izapolsk izapolsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@izapolsk izapolsk merged commit 37cba90 into ManageIQ:master Aug 31, 2017
@apagac apagac deleted the snpsht_powered_off branch September 13, 2017 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants