-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] test snapshot operations on powered off vm #5159
Conversation
Still references selenium. This will change after PR #5124 merge. |
PRT is failing on unrelated test, this will go away with PR #5126 merge. |
d73bd9c
to
eb5d94a
Compare
Now waiting for PR #5124 that contains fix for NameError and snapshot.refresh. |
eb5d94a
to
30d0503
Compare
PRT 5.7 fails on unrelated test, so moving this to RFR. Dependent PR was merged, this was rebased and refactored. |
small_test_vm.power_control_from_cfme(option=small_test_vm.POWER_OFF, cancel=False) | ||
small_test_vm.wait_for_vm_state_change(desired_state=small_test_vm.STATE_OFF) | ||
# Create first snapshot | ||
snapshot1 = new_snapshot(small_test_vm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question for second level review: should we consider having a helper for the creation of a snapshot as a followup with a more nice api as this test needs to do quite some plumbing due to low level of the api provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be resolved with collections? You should then be able to do something like vm.snapshots.create(...)
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfalesni perfect point, thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is a new test for testing basic snapshot operations on a powered off vm.
Snapshot create, revert and delete.